chm252 / pe

0 stars 0 forks source link

Find bill should allow integers #14

Open chm252 opened 1 year ago

chm252 commented 1 year ago

Screenshot 2022-11-11 at 4.53.51 PM.png Currently find bill needs us to type "find x.xx". As it is common for bills to end with ".00" such as when customers first arrived at the room, it should start with $0. Considering your user guide mentioned that cost of room booking should not be included. I would expect pretty many $0.00 bills in your list. To expedite the finding, allowing us to type integer instead of making it mandatory to type "0.00" can greatly ameliorate the searching process. This is especially true if we want to sieve out all those who just started using the hotel rooms. Thanks.

nus-se-bot commented 1 year ago

Team's Response

We believe that this bug is not in scope as it is not very important and allows the user to be more specific in searching. For a hotel manager to sieve out those who just started using the hotel rooms, they can simply search "0.00" for the bill as well. We mark this as not in scope as our time is better spent on other features.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The team mentioned "For a hotel manager to sieve out those who just started using the hotel rooms, they can simply search "0.00" for the bill as well."

I disagree because it should have been implemented such that the integers are accepted given that find 0 will be a very common usage by hotel managers (as explained in my PE bug report). In addition, there is almost no drawbacks in allowing integers for find bill.

Restricting it to be in the form "x.xx" when there is a better option of allowing integers for find bill, this itself is very unoptimised for the target users, which is a feature flaw.