search

chmarti1 / PYroMat

PYroMat thermodynamic properties in Python
http://pyromat.org
Other
71 stars 13 forks source link

Typo bug in igmix.py #41

Closed jranalli closed 2 years ago

jranalli commented 2 years ago

Call in igmix.py should be pm.units.temperature_scale()

chmarti1 commented 2 years ago

This looks like a second instance of a similar bug already fixed. igmix didn't receive much scrutiny in the last release beyond folding in the new _argparse() algorithm. It looks like it's time to go back over some of the dustier corners.

jranalli commented 2 years ago

I think when you fixed it first time through you just left off the .units.

The test code I have has pretty complete coverage, so I don't think you need to overdo going back over it. If there's something busted hopefully the tests will catch it.

chmarti1 commented 2 years ago

This is an absolutely awful (rookie) mistake. After I made the original fix, I completely forgot to test the new Tlim() function. This time, I did not make the same mistake. This problem has been fixed in version 2.2.1.