Open chmarti1 opened 1 year ago
I thought about doing this when I wrote the state methods. There are a couple of reasons I decided not to do it yet, but that doesn't mean it will never happen
Still, I think this is still a good idea, so it's worth opening it for discussion.
2. In my opinion, promoting a dictionary to a class is best done only when implementing class methods is important. The state class would merely be a container for the property values.
Thinking out loud here, so please excuse. One method that would maybe be of value is wrappers for quickly converting the units for all properties an already computed state. But that doesn't necessarily have to be a class function as opposed to a function that can operate on the dict. The one advantage I could see for a class approach would be to carry the units along with the values as an extra field. In principle that could happen with the dict but might be messier?
This was originally posted by @DanielSarmiento04 as a comment in #77. I've re-posted it here because it's an interesting idea.
Originally posted by @DanielSarmiento04 in https://github.com/chmarti1/PYroMat/issues/77#issuecomment-1397545933