search

chmarti1 / PYroMat

PYroMat thermodynamic properties in Python
http://pyromat.org
Other
71 stars 13 forks source link

Add Ideal Rankine Cycle jupyter notebook tutorial #82

Open adriaan90 opened 1 year ago

adriaan90 commented 1 year ago

Good day

I saw in the discussions under the Ideas section the need for a tutorial in the jupyter notebook format. The Ideal Rankine Cycle is an appropriate problem to use to showcase the use of PYroMat.

I am happy to make changes as required by you.

Thank you for the opportunity

Adriaan van Niekerk

chmarti1 commented 1 year ago

Thanks so much for contributing your code and your time! I won't be able to give it the attention it deserves for a little while. I will. In the meantime, thanks very much for your work, and thanks for using PYroMat!

adriaan90 commented 5 months ago

@chmarti1 I see it has been more than a year since I created the pull request. Please do not hesitate to let me know of any shortfalls that I need to address for this pull request to be successful. Thanks

chmarti1 commented 1 month ago

It's been a long time - that's true. I've been working to get through the mounting to-do list for the project. These pull requests are still on my to-do list, but they aren't the most urgent yet. Please know I really do value your work. I'm planning to circle around with the rest of the team soon and discuss.