chmarti1 / PYroMat

PYroMat thermodynamic properties in Python
http://pyromat.org
Other
71 stars 13 forks source link

Error in R1234ze Saturation Density #86

Closed chmarti1 closed 1 month ago

chmarti1 commented 9 months ago

In version 2.2.4, there is an error in the saturated liquid density model for R1234ze (mp.C3H2F4_1). One of the empirical coefficients was incorrectly entered. The model still passes its integrity checks recommended by the original paper, but the saturation property calculations are not correct. This problem has already been fixed in the planned release of version 2.2.5.

If you want to correct it yourself in your own release, open /your/pyromat/installation/dir/data/mp/C3_H2_F4_1.hpd Line 96 reads 1.9696 It should read 2.2456

chmarti1 commented 1 month ago

This issue is resolved in v2.2.5. There was also an error in the vapor saturation line due to an incorrect ordering of the coefficients in the raw data file. Both issues are addressed.