search

chmduquesne / rollinghash

Implementation of some rolling hashes in go
MIT License
64 stars 11 forks source link

ENH Allow caller to set bytehash in buzhash #4

Closed kshedden closed 7 years ago

kshedden commented 7 years ago

I need to be able to set the bytehash table in buzhash when calling New (to create multiple independent rolling hashes). It's an easy extension (I created an alternative New called NewWithByteHash). I can make a PR if you are interested.

chmduquesne commented 7 years ago

No problem with that, I will accept a PR if you make one.

However, for the sake of consistency, please name your method NewFromByteArray, in order to reflect the naming scheme adopted with NewFromInt in rabinkarp32.

FYI in the next version of rollinghash, buzhash will be renamed to buzhash32 and I will add a buzhash64 version.