Search genre functionality

chme / forked-daapd-web

Web interface for forked-daapd

GNU General Public License v2.0

2 stars 0 forks source link

Search genre functionality #6

Closed whatdoineed2do closed 6 years ago

whatdoineed2do commented 6 years ago

dependency on merge of https://github.com/ejurgensen/forked-daapd/pull/559

Added genre as additional tab/page (#/music/genres) which will display all genres. Clicking on a genre will list all albums matching the genre.
ability to play or add from genre like we can for albums etc
~~Search (#/search/library) also includes genre when request is made to backend~~

chme commented 6 years ago

Just wanted to let you know, that I hope to find time over the coming weekend to look into and test this pr (together with the one against forked-daapd).

whatdoineed2do commented 6 years ago

commits squashed - awaiting final review/merge in https://github.com/ejurgensen/forked-daapd/pull/559 before we consider this PR for merge here

whatdoineed2do commented 6 years ago

Very much appreciate the feedback/patience on this one. Changes added.

"Is it intentional that queuing an album for a genre, will queue all tracks of this album, even the tracks that do not match the genre?"

Yes this was intentional - I thought of doing this 'add/play' based on the genre for each tracks but I think the overhead of pulling each track and examining it was too costly so when the server gives us the list of albums 'matching' a genre we can use that.

It's not perfect but to save on the cost of doing it properly is probably not worth it.

chme commented 6 years ago

@whatdoineed2do i think, this is good to be merged. Could you make a pr against ejurgensens forked-daapd git-repository?

whatdoineed2do commented 6 years ago

Thanks - PR https://github.com/ejurgensen/forked-daapd/pull/598 already submitted as part of a bigger usability feature set that I've had on my live system for a while

Can you review?