chmln / handlr

A better xdg-utils
MIT License
608 stars 24 forks source link

handlr incorrectly handling `Terminal` property with launch command #66

Open LordMZTE opened 1 year ago

LordMZTE commented 1 year ago

The Terminal property in a .desktop file specifies, whether an application will start it's own GUI or needs to be run from inside a terminal emulator, so a desktop file with Terminal=true should have its command run inside a terminal emulator, for example alacritty -e $COMMAND. handlr misinterprets this, hiding a command's output if it's set to false and never launching a terminal emulator.

The result of this is that output will be needlessly hidden for most applications, and some applications, such as htop.desktop will fail to correctly launch, as their TUI will be hidden when launched from a UI that doesn't show handlr's output.

EDIT: There seems to be no clear specification on what terminal emulator to use. GNOME's stack just tries some known ones. Maybe handlr can find a more elegant solution.