Process killed when floating popup window gets focus

chmln / i3-auto-layout

Automatic, optimal tiling for i3wm

145 stars 19 forks source link

Process killed when floating popup window gets focus #3

Closed rickjansen-dev closed 4 years ago

rickjansen-dev commented 4 years ago

I ran into a bug where the process is killed when a floating popup window gets focus. To reproduce:

Open a floating popup window, for example:
- Open gnome terminal, open the preferences window (edit=>preferences)
- Or open Deluge and click on Add Torrent to open the add torrent window
If the process isn't killed already, make sure the popup window gets focus to kill it

Now the root cause is an issue in tokio-i3ipc: https://github.com/leshow/tokio-i3ipc/issues/3 Which is fixed and building i3-auto-layout from source should work, since that would pull the latest from that repo, but it doesn't because the Cargo.lock file is in the repo (and not in the .gitignore) removing it and rebuilding fixes the issue

chmln commented 4 years ago

Hey @vuurbeving,

Thanks a lot for digging into this!

Which is fixed and building i3-auto-layout from source should work, since that would pull the latest from that repo, but it doesn't because the Cargo.lock file is in the repo (and not in the .gitignore)

The lockfile is there for reproducible builds. And now that tokio-i3ipc is out with the fix, I will upgrade the dependency to use the release version and avoid situations like this in the future.

Thanks again.