search

chmln / sd

Intuitive find & replace CLI (sed alternative)
MIT License
5.77k stars 136 forks source link

Allow for many find and replaces #241

Closed dev-ardi closed 10 months ago

dev-ardi commented 11 months ago

133

dev-ardi commented 11 months ago

Done. Caveats: 2 extra vector allocations at the start (should be completely negligible)

  1. changed public API of Replacer::new()
  2. There's probably a more efficient way of achieving what replace does
  3. No colors when there are several patterns.
  4. The regex flags are applied to all patterns
CosmicHorrorDev commented 10 months ago

I'll be looking at these after I get this pending release out. Just wanted to give a heads up that I'm not ignoring all of these

dev-ardi commented 10 months ago

What's left for the release? The release issue tracker #203 is as complete as it gets.

Can I help with anything?

dev-ardi commented 10 months ago

This will be a hacky solution up until the new modular architecture is created and merged. I don't know if it's worth it to release it for 1.1 since the API for it will likely change

dev-ardi commented 10 months ago

This doesn't make much sense after #282