search

chmln / sd

Intuitive find & replace CLI (sed alternative)
MIT License
5.72k stars 136 forks source link

Remove warning when using `--preview` on stdin input #259

Closed CosmicHorrorDev closed 10 months ago

CosmicHorrorDev commented 10 months ago

This reverts #239

I agreed with the motivation from the original PR, but I have since changed my mind. Currently using --preview when dealing with input from stdin is identical to not passing --preview, hence the idea behind the warning.

The reason that I changed my mind is that I now view those two matching to be just a coincidence. The output of --preview is likely to change in the future to be more human friendly while not passing --preview should always pass the full expected output so it can be piped to other programs, files, etc. Because this is likely to change in the future I don't think we should dissuade users from passing --preview while dealing with stdin input

dev-ardi commented 10 months ago

In this case we should change the docs on the preview flag to something more descriptive. Right now it is

    /// Output result into stdout and do not modify files.
    pub preview: bool,