Closed ifelere closed 6 years ago
Hello @ifelere
Thanks a lot for contributing! I've left some remarks, but they should be easy to resolve.
@ifelere that's great you were able to customize it this much. It was easy because the library is architected in a simple and modular way, and I'd like to keep it that way.
However, I'm not a fan of the dialog and as it stands the PR is far too big (+1000 lines) and will bloat the codebase. I can't accept it in its current shape. You may either make the changes or if you wish, you are welcome to maintain your own fork.
I'd like to thank you for a great job on this. It was very simple to serve my needs. Nevertheless I need to customize the behavior of the link module by disabling it and introduce my customized module that does not allow arbitrary urls.