search

chmod222 / libcmmk

An unofficial LED control API for Coolermaster Masterkey keyboards
GNU Lesser General Public License v3.0
100 stars 24 forks source link

Help with mapping US layout and MasterKeys Pro S #5

Closed pokonski closed 5 years ago

pokonski commented 5 years ago

Hey @chmod222!

I mapped keys for my MasterKeys Pro S with US layout to work with your lib. Are you accepting PRs or is it abandoned?

HaoZeke commented 5 years ago

I was just about to start on a Pro L US layout.. I guess you ought to try a PR.

chmod222 commented 5 years ago

Hey,

the project is not entirely abandoned, no. But it currently does everything I needed it to do when I first set out writing it, so I don't have any immediate or long term plans right now.

That said, do feel free to send me pull requests. I can't really test different layouts because I only have one model, but I'll get around to merging them if they compile cleanly.

pokonski commented 5 years ago

@HaoZeke do you have a full width keyboard? Mine doesn't have numpad so can't map that part.

HaoZeke commented 5 years ago

Yup, I have the large variety which includes the numpad.

ku1ik commented 5 years ago

I'd be happy to help test the PR on my Pro S (US) 🙌

pokonski commented 5 years ago

@HaoZeke @sickill have a look! https://github.com/chmod222/libcmmk/pull/7

My C is super rusty so it can definitely be improved.