search

chmoder / criterion.dev

The official support channel for https://api.criterion.dev and https://criterion.dev
https://criterion.dev
6 stars 0 forks source link

The action doesn't seem to work if you have tests #1

Open CryZe opened 4 years ago

CryZe commented 4 years ago

When I run cargo bench on my project, it seems to also look for benchmarks in my tests or so (?) at which point it fails to recognize the options passed to criterion and cargo bench errors out. This then causes the action to fail.

https://github.com/LiveSplit/livesplit-core/runs/1179311859?check_suite_focus=true#step:3:385

chmoder commented 3 years ago

Sorry for the delay here, I was on vacation. Did you happen to resolve this already or do you need some assistance?

chmoder commented 3 years ago

Hi, this issue appears to be upstream of even the core criterion library. There is an issue open at rust-lang about it as well.

The good thing is that the criterion docs explain how to fix this. Unfortunately at this time it has to be part of the users particular project.

I think I will keep this issue open because rust-lang/rust#47241 may some day have a resolution we can implement here at criterion.dev.