Closed mahavirj closed 1 year ago
@chmorgan I observed this issue in the context of https://github.com/espressif/esp-box/pull/18.
@chmorgan Additionally can you please consider dropping a license file in this and your other IDF managed components repository CC @tore-espressif @igrr
@chmorgan Please create new tag to publish this change on the IDF component manager
@mahavirj added license file and pushed out v1.0.3
I’ll try to get to this tonight, along with the license file.
On Fri, Sep 30, 2022 at 10:18 AM Mahavir Jain @.***> wrote:
@chmorgan https://github.com/chmorgan Please create new tag to publish this change on the IDF component manager
— Reply to this email directly, view it on GitHub https://github.com/chmorgan/esp-audio-player/pull/1#issuecomment-1263637494, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJH4AAW245IKKU3MNP2VLLWA3ZETANCNFSM6AAAAAAQXTWC54 . You are receiving this because you were mentioned.Message ID: @.***>
Thank you for the PR. I’ll take a look this evening and add the license file as well.
On Wed, Sep 28, 2022 at 6:26 AM Mahavir Jain @.***> wrote:
@chmorgan https://github.com/chmorgan Additionally can you please consider dropping a license file in this and your other IDF managed components repository CC @tore-espressif https://github.com/tore-espressif @igrr https://github.com/igrr
— Reply to this email directly, view it on GitHub https://github.com/chmorgan/esp-audio-player/pull/1#issuecomment-1260704042, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJH4AAGQG7AJRWWHOLZPTLWAQMMZANCNFSM6AAAAAAQXTWC54 . You are receiving this because you were mentioned.Message ID: @.***>
This fixes the build issue with ESP-IDF v5.x. Component dependency must be explicitly specified, earlier this might be getting resolved through other components.