search

chmorgan / esp-audio-player

Apache License 2.0
14 stars 5 forks source link

arch: add RISCV support #6

Closed espressif2022 closed 1 year ago

espressif2022 commented 1 year ago

add RISCV support for esp32-c3/c3/c6.

espressif2022 commented 1 year ago

I don’t know where the file cppcheck failed, can you help me to look it up.

chmorgan commented 1 year ago

Hey @espressif2022 I missed this until today, sorry about that. Yes of course, I'll take a look and help get this working tonight.

chmorgan commented 1 year ago

@espressif2022 would you mind rebasing against main and pushing? I'd like to see if the cppcheck v1.4 actions either fixes the issue or lets us see what is going on. In any case, the changes look good and I'll merge in the near future.

espressif2022 commented 1 year ago

@espressif2022 would you mind rebasing against main and pushing? I'd like to see if the cppcheck v1.4 actions either fixes the issue or lets us see what is going on. In any case, the changes look good and I'll merge in the near future.

cppcheck v1.4 is ok, thanks.

chmorgan commented 1 year ago

Thank you for the pr, merged.

espressif2022 commented 1 year ago

Thank you for the pr, merged.

OK, look forward to the update of the new components version.

chmorgan commented 1 year ago

@espressif2022 v1.0.5 pushed to components repository. Thanks for the contribution, there haven't been too many so far, hoping that's because its working well for people.