Fix VFS File Name Buffer Handling

chmorgan / libesphttpd

Libesphttpd - web server for ESP8266 / ESP32

Mozilla Public License 2.0

128 stars 45 forks source link

Fix VFS File Name Buffer Handling #35

Closed tidklaas closed 6 years ago

tidklaas commented 6 years ago

util/esp32_httpd_vfs.c:

initialise file name buffer before using strcat()
fix inconsistent use of tabs/spaces for indentation

chmorgan commented 6 years ago

Thanks for the PR!

phatpaul commented 5 years ago

Hi @tidklaas Did you test the cgiEspVfsUpload() function? I'm not saying it worked before your change, but it doesn't work for me. Please see my bug report: https://github.com/chmorgan/libesphttpd/issues/44

tidklaas commented 5 years ago

No, I have only used the download function and ran into the issue with the uninitialised filename buffer. Since the upload function had the same bug, I fixed it there too.

phatpaul commented 5 years ago

OK, just checking to make sure I don't break what was working for someone else.

Seems the original author contributed these functions "as is" and untested. https://github.com/chmorgan/libesphttpd/pull/24