Small fixes necessary to enable the SSL mode:

chmorgan / libesphttpd

Libesphttpd - web server for ESP8266 / ESP32

Mozilla Public License 2.0

128 stars 45 forks source link

Small fixes necessary to enable the SSL mode: #99

Closed M-Bab closed 2 years ago

M-Bab commented 3 years ago

openssl is a required esp-idf component
continue is not allowed outside of loops -> replace with return

phatpaul commented 3 years ago

I haven't used SSL mode with this library. Can someone else review please?

M-Bab commented 3 years ago

Well @phatpaul you can simply verify by enabling the SSL feature via sdkconfig. The original branch will not even build and after the changes in this PR it will.

danngreen commented 2 years ago

I can confirm these changes allow the library to compile with SSL enabled, in fact I made identical changes on my own before seeing this PR.

phatpaul commented 2 years ago

Sorry for the delay. I'm OK with the first commit. It didn't break anything on my end.

But it would be nice to have an easy way to test it. Would you please add code to the example project which makes use of SSL, but is only enabled if CONFIG_ESPHTTPD_SSL_SUPPORT == 1.

The two later commits break my build, would you please separate those from this PR?