search

chmouel / gosmee

Command line server and client for webhooks deliveries (and https://smee.io)
https://hook.pipelinesascode.com
Apache License 2.0
37 stars 14 forks source link

Suggestion: Add to the log of the events the date #64

Closed cmoulliard closed 1 year ago

cmoulliard commented 1 year ago

Suggestion

Add to the log of the events the date as currently it is very difficult to verify if the events coming from github can be matched with what the client reports locally (or using a pod).

check_run event replayed to http://pipelines-as-code-controller.pipelines-as-code.svc.cluster.local:8080, status: 200
check_suite event replayed to http://pipelines-as-code-controller.pipelines-as-code.svc.cluster.local:8080, status: 200

Ideally we should report

GithubApp ID or Webhook | Date | EventType | message
chmouel commented 1 year ago

yes that's a good suggestion

portante commented 1 year ago

PR #78 add the X-GitHub-Delivery header as the event ID, which is the value posted on the GitHub Webhooks page to make it easier to track.

I'll be adding another PR to add the date.

portante commented 1 year ago

Timestamp support added in PR #79.