search

chmp / ipytest

Pytest in IPython notebooks.
MIT License
314 stars 17 forks source link

Latest release has an undeclared IPython depencency #43

Closed xhochy closed 4 years ago

xhochy commented 4 years ago

See the failing CI in the conda recipe: https://github.com/conda-forge/ipytest-feedstock/pull/2

Either this should be lazily imported or ipython should be listed in the setup.py.

chmp commented 4 years ago

Thanks for the report :). I kinda knew that playing fast and loose with my dependencies is probably not a overly great idea, but it has been causing quite a lot of trouble in the last weeks.

chmp commented 4 years ago

I pushed a new 0.9.1 release with ipython as dependency

chmp commented 4 years ago

Damn. Saw the next failed test. I guess pytest finally removed py.* as a depedency

chmp commented 4 years ago

@xhochy not sure what goes wrong. Pytest still declares py as a depedency, I in turn depend on pytest. AFAIK, installing ipytest should install both pytest and py. No idea what the pipeline fails:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=183876&view=logs&j=1bf226d3-0e2f-52d8-fa93-7d9e633347b3&t=c09a5a47-eec3-5700-9284-6f1bd7b23501&l=564

xhochy commented 4 years ago

The correct dependencies were missing from the recipe, all fine now.

chmp commented 4 years ago

Perfect. Thanks :)