chniter / bstreeview

Bootstrap Treeview, A very simple plugin to build a basic and elegant Treeview with bootstrap 4. See the demo:
https://chniter.github.io/bstreeview/
Apache License 2.0
367 stars 53 forks source link

Error running unminified js #5

Closed Flyer53 closed 4 years ago

Flyer53 commented 4 years ago

First of all thanks for this project 👍

Describe the bug Running the unminified js file causes an error (I tried on desktop FF and Chrome) bstreeview 2020-03-09 092047 In order to contribute it would be great if I could run the unminified js file.

Thanks, Stefan

chniter commented 4 years ago

Hello Stefan,

Thanks for feedback 👍 You downloaded the release v1.0.0 or you are trying the plugin from the Master branch?

Flyer53 commented 4 years ago

Hi Sami, Thanks for the quick reply... and yes, I downloaded the master branch. I wanted to add some code so that each nav item gets a customized href attribute value. But maybe you have that already on your todo list :smirk:

chniter commented 4 years ago

Yes, i will add href attribute into option parameter. I will check the error iof the unminified js file. Try to download the release v1.0.0. It work fine.

chniter commented 4 years ago

After testing the unminified js file, i haven't the erro, can you share with me more details about the example that you are doing?

Flyer53 commented 4 years ago

I can confirm that the file from the bstreeview-1.0.0.zip download works without error while the file from bstreeview-master.zip causes the error. I compared the two bstreeview.js files and found they are different in spite of having the same version number.

bstreeview

Adding the missing line of code to the one file eliminates the error.

chniter commented 4 years ago

Hi Stefan,

Thanks for details. I will check this. 👍

Flyer53 commented 4 years ago

My pleasure Sami,

One more proposal: I think it would also be a good idea to be able to add a custom css class to the individual nav items. So you could add custom styles depending on menu level.

chniter commented 4 years ago

Nice idea!

chniter commented 4 years ago

Another @Flyer53 done staff !