search

chnm / anthologize

Anthologize is a free, open-source, WordPress-based platform for publishing. Grab posts from your WordPress blog, pull in feeds from external sites, or create new content directly in Anthologize. Then outline, order, and edit your work, crafting it into a coherent volume for export in several formats, including PDF, EPUB, and TEI.
http://anthologize.org
GNU General Public License v3.0
174 stars 28 forks source link

EPUB PEAR extension doesn't pass PHP 7.2 linting #91

Closed boonebgorges closed 6 years ago

boonebgorges commented 6 years ago

And possibly earlier. The fatals have to do with the use of $foo = &new Bar. I'm not sure when this was hard-deprecated.

Three options:

  1. Update the library. Problem: At a very quick first glance, I can't see where to find an updated version.
  2. Switch to another library. Problem: This takes a lot of work.
  3. Monkey-patch the instances

3 is perhaps the least lousy of the options, so it's likely what I'll do.

boonebgorges commented 6 years ago

I ended up going with a version of 1. See https://github.com/pear/File_Archive/. The master branch seems to have these problems fixed.

There are still a few linting errors, but they're just in the tests for one of the subpackages. This seems good enough for me.