search

chnm / rrchnm-wordpress

0 stars 1 forks source link

search results - image title consistency #115

Closed IdaAkiwumi closed 3 years ago

IdaAkiwumi commented 3 years ago

When using the search feature, the images show "avatar for". In https://github.com/chnm/rrchnm-wordpress/issues/102, we established other images having "profile picture for..". I think the same should apply here

example: Screen Shot 2020-10-15 at 11 39 57 AM

https://rrchnm.org/?s=news https://rrchnm.org/?s=annual+report

kimisgold commented 3 years ago

This should now be in line with the other avatar markup.

IdaAkiwumi commented 3 years ago

This is looking good, however WAVE is saying 2 nearby images have the same alt text.

Screen Shot 2020-10-19 at 10 28 48 AM "profile picture for" is repeated. Screen Shot 2020-10-19 at 10 29 28 AM

Example below:

search page used: https://rrchnm.org/?s=annual+report

kimisgold commented 3 years ago

The use of the wrong display name variable meant that all the alt text had blank spaces for names. It should now be fixed in https://github.com/chnm/rrchnm-wordpress/commit/23bd3670bd681bfd836637aa3999c434e33ea92e.