search

chnm / serendipomatic

http://serendipomatic.org/
26 stars 9 forks source link

After pasting text, clicking on input box deletes all text #104

Closed patrickmj closed 11 years ago

patrickmj commented 11 years ago

This behavior makes sense for getting rid of the default "hippo" text, but if I paste some text and want to make an edit, like completing a word that I didn't fully copy or removing a paragraph, this forces me back to recopying.

mialondon commented 11 years ago

Any advance on this for code logic: 'if the start of the text matches the sample text we provide, then clear it; if it doesn't, then don't'?

@erose (or anyone with a bit of javascript), do you think you could look at this? (It turns out I've got to turn around some journal edits today so I can't get to it.)

scottkleinman commented 11 years ago

I'll see if I can get around to this in the next day or so.

The alternative is the "Clear Form" button that I had in there for a while. Speak up if you would prefer one solution over the other.

Scott

On 4 August 2013 06:32, Mia notifications@github.com wrote:

Any advance on this for code logic: 'if the start of the text matches the sample text we provide, then clear it; if it doesn't, then don't'?

@erose https://github.com/erose (or anyone with a bit of javascript), do you think you could look at this? (It turns out I've got to turn around some journal edits today so I can't get to it.)

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/104#issuecomment-22071765 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

mialondon commented 11 years ago

Thanks Scott!

I have a feeling that 'clear form' buttons do more harm than good, and having two large buttons also reduces the visual prominence of the main call-to-action...

scottkleinman commented 11 years ago

Well, button size can be changed of course, but your point is well taken. I'll try the conditional logic first and see how people feel.

On 4 August 2013 07:55, Mia notifications@github.com wrote:

Thanks Scott!

I have a feeling that 'clear form' buttons do more harm than good, and having two large buttons also reduces the visual prominence of the main call-to-action...

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/104#issuecomment-22072946 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

erose commented 11 years ago

I changed how the default text was implemented last night (now loaded from smartstash/default.txt).

On Sun, Aug 4, 2013 at 11:14 AM, scottkleinman notifications@github.comwrote:

Well, button size can be changed of course, but your point is well taken. I'll try the conditional logic first and see how people feel.

On 4 August 2013 07:55, Mia notifications@github.com wrote:

Thanks Scott!

I have a feeling that 'clear form' buttons do more harm than good, and having two large buttons also reduces the visual prominence of the main call-to-action...

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/104#issuecomment-22072946> .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

—

Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/104#issuecomment-22073239 .

scottkleinman commented 11 years ago

Thanks. That will be much cleaner.

On 4 August 2013 08:18, Eli Rose notifications@github.com wrote:

I changed how the default text was implemented last night (now loaded from smartstash/default.txt).

On Sun, Aug 4, 2013 at 11:14 AM, scottkleinman notifications@github.comwrote:

Well, button size can be changed of course, but your point is well taken. I'll try the conditional logic first and see how people feel.

On 4 August 2013 07:55, Mia notifications@github.com wrote:

Thanks Scott!

I have a feeling that 'clear form' buttons do more harm than good, and having two large buttons also reduces the visual prominence of the main call-to-action...

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/104#issuecomment-22072946>

.

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

—

Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/104#issuecomment-22073239> .

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/104#issuecomment-22073296 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

erose commented 11 years ago

Ok, cool, glad it's helpful. I'm actually halfway into implementing this, so I can take it if you want.

On Sun, Aug 4, 2013 at 11:24 AM, scottkleinman notifications@github.comwrote:

Thanks. That will be much cleaner.

On 4 August 2013 08:18, Eli Rose notifications@github.com wrote:

I changed how the default text was implemented last night (now loaded from smartstash/default.txt).

On Sun, Aug 4, 2013 at 11:14 AM, scottkleinman notifications@github.comwrote:

Well, button size can be changed of course, but your point is well taken. I'll try the conditional logic first and see how people feel.

On 4 August 2013 07:55, Mia notifications@github.com wrote:

Thanks Scott!

I have a feeling that 'clear form' buttons do more harm than good, and having two large buttons also reduces the visual prominence of the main call-to-action...

— Reply to this email directly or view it on GitHub<

https://github.com/chnm/serendipomatic/issues/104#issuecomment-22072946>

.

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

—

Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/104#issuecomment-22073239>

.

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/104#issuecomment-22073296> .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

—

Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/104#issuecomment-22073402 .

scottkleinman commented 11 years ago

OK, feel free to take it over.

On 4 August 2013 08:27, Eli Rose notifications@github.com wrote:

Ok, cool, glad it's helpful. I'm actually halfway into implementing this, so I can take it if you want.

On Sun, Aug 4, 2013 at 11:24 AM, scottkleinman notifications@github.comwrote:

Thanks. That will be much cleaner.

On 4 August 2013 08:18, Eli Rose notifications@github.com wrote:

I changed how the default text was implemented last night (now loaded from smartstash/default.txt).

On Sun, Aug 4, 2013 at 11:14 AM, scottkleinman < notifications@github.com>wrote:

Well, button size can be changed of course, but your point is well taken. I'll try the conditional logic first and see how people feel.

On 4 August 2013 07:55, Mia notifications@github.com wrote:

Thanks Scott!

I have a feeling that 'clear form' buttons do more harm than good, and having two large buttons also reduces the visual prominence of the main call-to-action...

— Reply to this email directly or view it on GitHub<

https://github.com/chnm/serendipomatic/issues/104#issuecomment-22072946>

.

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

—

Reply to this email directly or view it on GitHub<

https://github.com/chnm/serendipomatic/issues/104#issuecomment-22073239>

.

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/104#issuecomment-22073296>

.

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

—

Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/104#issuecomment-22073402> .

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/104#issuecomment-22073435 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

erose commented 11 years ago

The fix has been pushed to master. I tested on my local server. Someone should close this once it can get tested for real.

rlskoeser commented 11 years ago

It's available on the dev-serendipomatic heroku auto-deploy server ( http://dev-serendipomatic.herokuapp.com/ ) if someone wants to look and test (works for me, but I only tested one browser and didn't check on mobile)

scottkleinman commented 11 years ago

Looking good. It works for me on Chrome, Firefox, and recent IE.

On 4 August 2013 13:45, Rebecca Sutton Koeser notifications@github.comwrote:

It's available on the dev-serendipomatic heroku auto-deploy server ( http://dev-serendipomatic.herokuapp.com/ ) if someone wants to look and test (works for me, but I only tested one browser and didn't check on mobile)

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/104#issuecomment-22078572 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

mialondon commented 11 years ago

And for me. Closing with the assumption it'll go live in the next push. Thanks all!