search

chnm / serendipomatic

http://serendipomatic.org/
26 stars 9 forks source link

Style error messages and check mobile display #139

Closed scottkleinman closed 10 years ago

scottkleinman commented 10 years ago

Just fix the error message placement on screen so it looks nice.

scottkleinman commented 10 years ago

I have introduced some nicer styling. The location of the error message above the Zotero box broke the layout on small screens. I've moved the error message to above the input textarea. How do people feel about that?

mialondon commented 10 years ago

I've only tested on my iPod touch but it's definitely better! The only thing is that it blends in a bit - maybe @fontnerd could advise on styling the error message so that it's prominent enough for people who might be in a bit of a dither?

scottkleinman commented 10 years ago

Agreed on the styling. I chose an error icon that matched the Zotero scheme and coloured the text to match it. But something that stands out more would be better.

On 13 August 2013 14:22, Mia notifications@github.com wrote:

I've only tested on my iPod touch but it's definitely better! The only thing is that it blends in a bit - maybe @fontnerdhttps://github.com/fontnerdcould advise on styling the error message so that it's prominent enough for people who might be in a bit of a dither?

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/139#issuecomment-22598663 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

mialondon commented 10 years ago

@fontnerd can you take a look at this to see if the design tweaks are ok by you?

fontnerd commented 10 years ago

whoops, sorry about that, @scottkleinman! I've just added a bit of a top margin to make the error message more obvious. Otherwise, looks ok to me!

mfrazer commented 10 years ago

Confirmed this one is good in dev (verified error with desktop, iPad and Android phone). The top margin helps set off the error message, also.

Will close once it's in production.

mfrazer commented 10 years ago

Verified in prod.