chnm / serendipomatic

http://serendipomatic.org/
26 stars 9 forks source link

Title link text runs over #64

Open moltude opened 11 years ago

moltude commented 11 years ago

Not a great example but the text is running below the image

screen shot 2013-08-02 at 11 31 32 am

mialondon commented 11 years ago

Rebecca's done title truncation to 80 characters, when new code is up let me know if that hasn't fixed it.

rlskoeser commented 11 years ago

This is assigned to me but I'm not certain what needs to be done or even if it's still an issue. @mialondon can you comment? Perhaps the recent changes @amandavisconti made to image alt text address this problem?

amandavisconti commented 11 years ago

I'm going to truncate the img alt text (which is drawn from the title), but that won't solve the issue of the title on the overlay being too big for the image. Do we want to also truncate that at a set size?

mialondon commented 11 years ago

Possibly. It's a shame that some of the thumbnails are so tiny, but short of removing them from the resultset we can't do much about that.

Do any of the API responses provide image dimensions? It'd be a shame to truncate titles unnecessarily (i.e. for bigger images) so if it's possible to detect small images (ideally server-side) and only truncate their titles that'd be preferable.

rlskoeser commented 11 years ago

I don't think any of the APIs give us information about thumbnail size, but it might be worth double-checking. Could we put the tiny images in a slightly larger div (e.g., some minimum size) that would be the masonry-level container and has more room for the text? (I say this not really knowing much of anything about how masonry works.)

mialondon commented 11 years ago

We did talk about that, I'm not sure whether it dropped off because it didn't work or because there was too much else going on. It seems worth a try, but I'll defer to @amandavisconti