search

chnm / serendipomatic

http://serendipomatic.org/
26 stars 9 forks source link

Vertical spacing of Zotero grey box #72

Closed moltude closed 11 years ago

moltude commented 11 years ago

There was a question about the height of the box and whether the

Go Need help or more info about Zotero?

Could be put on the same line to reduce the height of the box.

These are open questions.

mialondon commented 11 years ago

The 'go' button needs to be closer to the box.

If we put the 'need more info' and 'go' on the same line, they'll look related i.e. click go to find out more about Zotero.

We could try reducing the size of the username text box so it's on the same line as 'go' - that might help solve the problem. We'll need to re-test it all on mobiles, tablets, etc to see how it works at different sizes.

scottkleinman commented 11 years ago

The large amount of space is somehow a consequence of the Django-generated form. I ran out of time to try to fix this, but it should be possible to style either the form or the button to reduce the space between them. I'll look into it.

On 3 August 2013 13:30, Mia notifications@github.com wrote:

The 'go' button needs to be closer to the box.

If we put the 'need more info' and 'go' on the same line, they'll look related i.e. click go to find out more about Zotero.

We could try reducing the size of the username text box so it's on the same line as 'go' - that might help solve the problem. We'll need to re-test it all on mobiles, tablets, etc to see how it works at different sizes.

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/72#issuecomment-22061096 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

rlskoeser commented 11 years ago

If there's anything I can help with on the django side, please let me know.

scottkleinman commented 11 years ago

In the end, this required very minor css additions and the removal of a <br />. I've tested on Chrome, Firefox, and recent IE, and then pushed directly to the master branch. If someone can test the changes as OK on mobile, we can deploy and close this issue.

-S

On 4 August 2013 13:46, Rebecca Sutton Koeser notifications@github.comwrote:

If there's anything I can help with on the django side, please let me know.

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/72#issuecomment-22078595 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

mialondon commented 11 years ago

Looks ok on iPod Touch and tiny Android HTC.

The 'make some magic' button is still below the Zotero box - given people aren't likely to link to Zotero on their phones (at this stage), it should be above as the main call-to-action on mobile is probably just to try it with any text at all, let alone faff around with more extended processes. @scottkleinman are you able to look at that quickly?

scottkleinman commented 11 years ago

I think the location of the 'make some magic' button was a separate issue, but I can't find it now. I've also just seen Scott East's comment about horizontal alignment of the Zotero box with the textarea. I will try to implement the latter (which I'll open as a new issue) and push again. Assuming it works, I think we should go ahead and deploy these minor changes.

I'll then work on the 'make some magic' button and hopefully have a fix by the end of the day.

On 5 August 2013 09:31, Mia notifications@github.com wrote:

Looks ok on iPod Touch and tiny Android HTC.

The 'make some magic' button is still below the Zotero box - given people aren't likely to link to Zotero on their phones (at this stage), it should be above as the main call-to-action on mobile is probably just to try it with any text at all, let alone faff around with more extended processes. @scottkleinman https://github.com/scottkleinman are you able to look at that quickly?

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/72#issuecomment-22118210 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

mialondon commented 11 years ago

I'm going to close this as it's been superseded by the discovery that the Zotero bit doesn't even need the username box...