chnm / serendipomatic

http://serendipomatic.org/
26 stars 9 forks source link

When viewing on a narrow browser, the "make magic" button shows up below the Zotero box #80

Closed briancroxall closed 11 years ago

mialondon commented 11 years ago

I've only checked on my iPod but it seems to be ok now?

rlskoeser commented 11 years ago

As far as I can tell this never got fixed. I've just moved the button up under the textarea and adjusted the styles slightly. It seems like there is too much whitespace between the two inputs when the browser window gets narrow enough the zotero input flows below, but I wasn't sure how much to tweak. Part of this is the 70px margin-bottom on the magic button, and (I think) part of it is the "pipe one columns" spacer between the two inputs.

If someone else can take a look that would be great.

fontnerd commented 11 years ago

i'm taking a look at this now. i'm pretty sure w/ Scott K we came up with a solution to physically move the the "Make the Magic" button into a new div. This seemed to work for both desktop and mobile versions but I will check and see.

On Mon, Aug 5, 2013 at 10:29 PM, Rebecca Sutton Koeser < notifications@github.com> wrote:

As far as I can tell this never got fixed. I've just moved the button up under the textarea and adjusted the styles slightly. It seems like there is too much whitespace between the two inputs when the browser window gets narrow enough the zotero input flows below, but I wasn't sure how much to tweak. Part of this is the 70px margin-bottom on the magic button, and (I think) part of it is the "pipe one columns" spacer between the two inputs.

If someone else can take a look that would be great.

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/80#issuecomment-22154688 .

scottkleinman commented 11 years ago

Hmmm... Recent changes seem to have messed up the footer, but I'm not sure if it's some thing Rebecca or Amy pushed.

On 5 August 2013 19:48, Amy notifications@github.com wrote:

i'm taking a look at this now. i'm pretty sure w/ Scott K we came up with a solution to physically move the the "Make the Magic" button into a new div. This seemed to work for both desktop and mobile versions but I will check and see.

On Mon, Aug 5, 2013 at 10:29 PM, Rebecca Sutton Koeser < notifications@github.com> wrote:

As far as I can tell this never got fixed. I've just moved the button up under the textarea and adjusted the styles slightly. It seems like there is too much whitespace between the two inputs when the browser window gets narrow enough the zotero input flows below, but I wasn't sure how much to tweak. Part of this is the 70px margin-bottom on the magic button, and (I think) part of it is the "pipe one columns" spacer between the two inputs.

If someone else can take a look that would be great.

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/80#issuecomment-22154688> .

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/80#issuecomment-22155261 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

fontnerd commented 11 years ago

Yes, I'm noticing this now too...There are also issues w/ the container on the about and connect pages. I've not been touching the footer at all but I'd place my money on me screwing something up over Rebecca.

On Mon, Aug 5, 2013 at 11:51 PM, scottkleinman notifications@github.comwrote:

Hmmm... Recent changes seem to have messed up the footer, but I'm not sure if it's some thing Rebecca or Amy pushed.

On 5 August 2013 19:48, Amy notifications@github.com wrote:

i'm taking a look at this now. i'm pretty sure w/ Scott K we came up with a solution to physically move the the "Make the Magic" button into a new div. This seemed to work for both desktop and mobile versions but I will check and see.

On Mon, Aug 5, 2013 at 10:29 PM, Rebecca Sutton Koeser < notifications@github.com> wrote:

As far as I can tell this never got fixed. I've just moved the button up under the textarea and adjusted the styles slightly. It seems like there is too much whitespace between the two inputs when the browser window gets narrow enough the zotero input flows below, but I wasn't sure how much to tweak. Part of this is the 70px margin-bottom on the magic button, and (I think) part of it is the "pipe one columns" spacer between the two inputs.

If someone else can take a look that would be great.

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/80#issuecomment-22154688> .

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/80#issuecomment-22155261> .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/80#issuecomment-22156877 .

fontnerd commented 11 years ago

OK, I found an extra closing curly bracket in the media query of the .zot class I had edited, so I'm hoping that has something to do w/ the layout break.

On Mon, Aug 5, 2013 at 11:53 PM, Amy Papaelias amypapaelias@gmail.comwrote:

Yes, I'm noticing this now too...There are also issues w/ the container on the about and connect pages. I've not been touching the footer at all but I'd place my money on me screwing something up over Rebecca.

On Mon, Aug 5, 2013 at 11:51 PM, scottkleinman notifications@github.comwrote:

Hmmm... Recent changes seem to have messed up the footer, but I'm not sure if it's some thing Rebecca or Amy pushed.

On 5 August 2013 19:48, Amy notifications@github.com wrote:

i'm taking a look at this now. i'm pretty sure w/ Scott K we came up with a solution to physically move the the "Make the Magic" button into a new div. This seemed to work for both desktop and mobile versions but I will check and see.

On Mon, Aug 5, 2013 at 10:29 PM, Rebecca Sutton Koeser < notifications@github.com> wrote:

As far as I can tell this never got fixed. I've just moved the button up under the textarea and adjusted the styles slightly. It seems like there is too much whitespace between the two inputs when the browser window gets narrow enough the zotero input flows below, but I wasn't sure how much to tweak. Part of this is the 70px margin-bottom on the magic button, and (I think) part of it is the "pipe one columns" spacer between the two inputs.

If someone else can take a look that would be great.

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/80#issuecomment-22154688>

.

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/80#issuecomment-22155261> .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/80#issuecomment-22156877 .

scottkleinman commented 11 years ago

Looks like that was it. The footer's back to normal.

On 5 August 2013 21:13, Amy notifications@github.com wrote:

OK, I found an extra closing curly bracket in the media query of the .zot class I had edited, so I'm hoping that has something to do w/ the layout break.

On Mon, Aug 5, 2013 at 11:53 PM, Amy Papaelias amypapaelias@gmail.comwrote:

Yes, I'm noticing this now too...There are also issues w/ the container on the about and connect pages. I've not been touching the footer at all but I'd place my money on me screwing something up over Rebecca.

On Mon, Aug 5, 2013 at 11:51 PM, scottkleinman notifications@github.comwrote:

Hmmm... Recent changes seem to have messed up the footer, but I'm not sure if it's some thing Rebecca or Amy pushed.

On 5 August 2013 19:48, Amy notifications@github.com wrote:

i'm taking a look at this now. i'm pretty sure w/ Scott K we came up with a solution to physically move the the "Make the Magic" button into a new div. This seemed to work for both desktop and mobile versions but I will check and see.

On Mon, Aug 5, 2013 at 10:29 PM, Rebecca Sutton Koeser < notifications@github.com> wrote:

As far as I can tell this never got fixed. I've just moved the button up under the textarea and adjusted the styles slightly. It seems like there is too much whitespace between the two inputs when the browser window gets narrow enough the zotero input flows below, but I wasn't sure how much to tweak. Part of this is the 70px margin-bottom on the magic button, and (I think) part of it is the "pipe one columns" spacer between the two inputs.

If someone else can take a look that would be great.

— Reply to this email directly or view it on GitHub<

https://github.com/chnm/serendipomatic/issues/80#issuecomment-22154688>

.

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/80#issuecomment-22155261>

.

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

— Reply to this email directly or view it on GitHub< https://github.com/chnm/serendipomatic/issues/80#issuecomment-22156877> .

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/80#issuecomment-22157381 .

Scott Kleinman Professor of English Director, Center for the Digital Humanities California State University, Northridge

mialondon commented 11 years ago

I've tested it on iPod touch Safari, Android Firefox and Mac Firefox and it looks good!

I've no idea what I was thinking with my earlier close, sorry about that.