Add "Roy Rosenzweig" to "Center for History and New Media" in footer

[mialondon]

This should be committed so I'm closing with the assumption it'll go live in the next push to dev then live.

[mialondon]

Doh, it's not in the about and connect pages. Can we refactor so they use the same footer code?

[rlskoeser]

I think I fixed it for about/connect on dev but hasn't been pushed live.

Refactoring so they share the same footer code (and so all common page elements can be shared) is part of the intent of #103

[briancroxall]

I'm not seeing the Roy Rosenzweig on either "connect" or "about" pages on the dev version.

[rlskoeser]

Are you sure you're looking at the right dev site? http://dev-serendipomatic.herokuapp.com/ Or maybe something is cached on your browser? I see it on dev, and I think it is actually on production too. (Unless I am misunderstanding something / looking at the wrong thing).

With the template refactoring I did, the footers should now all be exactly the same on every page of the site, and if we need to change the footer we only need to do it in one place.

[fontnerd]

Correct, Rebecca! Now it just needs to be added to ALL pages. :)

On Thu, Aug 8, 2013 at 10:47 PM, Rebecca Sutton Koeser < notifications@github.com> wrote:

Are you sure you're looking at the right dev site? http://dev-serendipomatic.herokuapp.com/ Or maybe something is cached on your browser? I see it on dev, and I think it is actually on production too. (Unless I am misunderstanding something / looking at the wrong thing).

With the template refactoring I did, the footers should now all be exactly the same on every page of the site, and if we need to change the footer we only need to do it in one place.

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/92#issuecomment-22372570 .

[mialondon]

...except the 500 error page, as being the one static page it won't inherit anything from the templates.

[mialondon]

Is it because 'Center for History and New Media' appears twice in the footer, and one instance has RR and the other doesn't? So you're both right... (I love being able to say that). I've updated the footer so hopefully everyone can be properly right as soon as that makes it way to dev...

[fontnerd]

Looks like everything is updated now. Just a picky type thing, but the word "University" on the second line all by itself looks very weird. Is anyone against removing the
(line break) between the first and second sentence? Or placing the line break before "George" so that "George Mason University" would fall on the second line. I think either would look better than having the typographic "widow" on the 2nd line.

[rlskoeser]

Ha. I knew there must be something like that going on (showing up in two places). Thanks for finding that, @mialondon. It occurs to me that I might be able to make static content like the footer text shareable between the base template and the 500 template; I'll try to remember to look into that. (I also need to test the 500 because the last time I saw it I wasn't sure it was showing up correctly.)

@fontnerd I agree about the weird line break- I'd rather drop the line break rather than adding another one (if we add one what happens on mobile or narrower displays?).

[rpalin]

I agree with @rlskoeser re no line break.

[fontnerd]

Yes, removing the line break is best. On smaller displays, the type will wrap accordingly so I wouldn't anticipate this being an issue.

On Sat, Aug 10, 2013 at 12:16 PM, rpalin notifications@github.com wrote:

I agree with @rlskoeser https://github.com/rlskoeser re no line break.

— Reply to this email directly or view it on GitHubhttps://github.com/chnm/serendipomatic/issues/92#issuecomment-22442511 .

[briancroxall]

Closing this as the footer text is now correct. The line break seems to be a different issue.