chobie / jira-api-restclient

php JIRA REST API
MIT License
217 stars 123 forks source link

createRemotelink: capitalize globalId properly #178

Closed glensc closed 5 years ago

glensc commented 5 years ago

By docs the JSON key is globalId not globalid.

JIRA version at https://pycontribs.atlassian.net does not accept wrongly cased key.

aik099 commented 5 years ago

Nice catch. Likely due wrongly specified global ID the created remote link has auto-generated ID, that can't be used to update that link later on.

Please also change CHANGELOG.md file.

glensc commented 5 years ago

updated.

and yes, with wrongly provided globalId it creates new link each time instead of updating existing one. that's why i needed a fix, as i update the link title in my project.

aik099 commented 5 years ago

Merging, thanks @glensc .

glensc commented 5 years ago

btw, jira itself is annoying, it leaves activity comment for each update even if the globalId is present and other payload is identical.

so, for my own solution, i might need to keep track of updated remote links locally or find a way to query existing remote links and update only non-matching ones.