rename createRemotelink -> createRemoteLink

chobie / jira-api-restclient

php JIRA REST API

MIT License

218 stars 123 forks source link

rename createRemotelink -> createRemoteLink #183

Closed glensc closed 5 years ago

glensc commented 5 years ago

Fixes "1" from #120:

it's name violates camelCase naming rules, where each word (except 1st one) in method name must be capitalized (should be Api::createRemoteLink)

method names are case insensitive in PHP, unless there's some magic getters/setters behind, this change is backward compatible.

cc @aik099

glensc commented 5 years ago

I mean, that the change will not break any logic as method names are case insensitive in PHP, unless some set or get is involved, I'm not familiar with the codebase.

glensc commented 5 years ago

so this goes under changes or added or err?

not sure this needs changelog entry, as you said, the code was not released.

changing case of previous changelog entry seems also weird.

- Added `Api::createRemotelink` call for creating linking issue with remote applications by [@elmi82].

aik099 commented 5 years ago

This change should go under changed. Yeah, a bit weird theoretically, but since different people added method and changed it I see no logical conflict.

aik099 commented 5 years ago

Merging, thank you @glensc .