search

chobie / jira-api-restclient

php JIRA REST API
MIT License
217 stars 123 forks source link

Apply code style fixes #184

Open glensc opened 5 years ago

glensc commented 5 years ago

Minor code style fixes done with help of php-cs-fixer.

glensc commented 5 years ago
  1. not directly. i was about to make changes, but noticed is_null in place
  2. i don't use the tool. shouldn't travis complain on this?
aik099 commented 5 years ago
  1. not directly. i was about to make changes, but noticed is_null in place

I see.

  1. i don't use the tool. shouldn't travis complain on this?

It's not doing that currently. It makes sense to do only, when we fix all existing issues to avoid all new build be broken by default.

glensc commented 5 years ago

checked vendor/bin/phpcs, the changes here are not related.

aik099 commented 5 years ago

Maybe can combine all CS fixes into single PR? I've just updated composer.json and composer.lock to ensure that used CS is compatible with latest PHP_CodeSniffer version.

PHP_CodeSniffer also does support auto-fixing of most, but not all issues found.

If you're using PhpStorm, then you configure it to automatically highlight problematic places.

We're not using Scrutinizer CI or otherwise it will be showing CS issues online as well.

glensc commented 5 years ago

You can squash merge from GitHub web UI if you have enabled that in project. If that's what you mean by single commit.

glensc commented 5 years ago

At this moment, I do not plan to make more CS fixes.