search

chobie / jira-api-restclient

php JIRA REST API
MIT License
217 stars 123 forks source link

Deprecation warnings #199

Closed dereuromark closed 2 years ago

dereuromark commented 2 years ago

https://github.com/chobie/jira-api-restclient/blob/master/src/Jira/Api.php#L713

$url should be $url = null or alike to avoid

PHP Deprecated:  Required parameter $url follows optional parameter $method in /home/travis/build/spryker/release-app/vendor/chobie/jira-api-restclient/src/Jira/Api.php on line 711
PHP Deprecated:  Required parameter $endpoint follows optional parameter $data in /home/travis/build/spryker/release-app/vendor/chobie/jira-api-restclient/src/Jira/Api/Client/CurlClient.php on line 62
PHP Deprecated:  Required parameter $credential follows optional parameter $data in /home/travis/build/spryker/release-app/vendor/chobie/jira-api-restclient/src/Jira/Api/Client/CurlClient.php on line 62
PHP Deprecated:  Required parameter $endpoint follows optional parameter $data in /home/travis/build/spryker/release-app/vendor/chobie/jira-api-restclient/src/Jira/Api/Client/ClientInterface.php on line 53
PHP Deprecated:  Required parameter $credential follows optional parameter $data in /home/travis/build/spryker/release-app/vendor/chobie/jira-api-restclient/src/Jira/Api/Client/ClientInterface.php on line 53
aik099 commented 2 years ago

@dereuromark , since an API request can't be made without specifying an URL I instead recommend removing the default value for the $method parameter coming before the $url parameter.

Please send a PR and would happily merge it.

P.S. Such deprecation warning started to happen on PHP 8.0 (see https://php.watch/versions/8.0/deprecate-required-param-after-optional).

dereuromark commented 2 years ago

Released as https://github.com/dereuromark/jira-api-restclient/releases/tag/1.1.0