Closed cypres closed 11 years ago
Hi, this is nice PR!
- A way to disable the feature via (php) option or otherwise
do you have some time to implement this feature?
Sure I can add way to toggle it on and off. I need to work out how to keep both features with minimal code impact, but I'll work on it next week. Preferably while also keeping support for (php).namespace option.
I should also add some new tests if you want to merge it.
Sorry for the delay. I'm pretty tied up currently. I've re-worked the feature to apply more cleanly, and for it to be optional. Unit testing still missing atm.
@duedal Thank you. It looks good to me. I want testcases. But It does not required atm as protoc-gen-php don't have it.
could you send another unit test PR when you have time?
Thank you, will send a PR with tests later, if all goes well I should be able to find the time next week.
@duedal btw, what testing framework do you use for this? I'd like to add gtest for conformance test. Please tell me current status
Been working on rudimentary support for package based namespaces.
It needs some additional work before it should/could be merged, but I thought I would post it anyway. Especially the following would be nice:
It works though, so if you really need/want namespaces it's usable.