search

chobie / php-sundown

php-sundown is just simple wrapper of sundown
Other
137 stars 16 forks source link

Make travis report test failure since make test didn't report exit code #23

Closed reeze closed 12 years ago

reeze commented 12 years ago

Hi, chobie,

make test didn't report exit code properly, even make test failed, travis will not complain.

please refer: https://github.com/reeze/php-leveldb/blob/master/travis/run-test.sh https://bugs.php.net/bug.php?id=60285

Look at this one, test failed but reported sucess http://travis-ci.org/#!/reeze/php-sundown/jobs/1670528

if test failed, cat will output the diffs, it will help us debugging :)

Thanks

chobie commented 12 years ago

thanks @reeze. I didin't know that.

probably we should use phpunit as it can test on windows box. I'll add it to next release.

reeze commented 12 years ago

thanks for quick repsonse :)

run-tests.php could run on windows too. do you Rakefile stuff?

chobie commented 12 years ago

run-tests.php could run on windows too.

really? I also don't know this. I guess phpunit is easier than run-tests.php. I'll test it later.

do you Rakefile stuff?

nope. redcarpet uses Rakefile so I just use it.