search

chobie / php-sundown

php-sundown is just simple wrapper of sundown
Other
137 stars 16 forks source link

Buildflags #36

Open remicollet opened 10 years ago

remicollet commented 10 years ago

Hi,

CFLAGS is set in config.m4. This is a bad practice as this don't honor default build flags used in downstream distribution.

As you only add warnings, probably you can omit those.

Else, please use CFLAGS="CFLAGS ..."

FYI, fedora use : "-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic" and I often add "-Werror"

for now, I will use sed -e 's/CFLAGS/IGNORED/' -i config.m4

remicollet commented 10 years ago

FYI, with -Wall, we have various warnings (nothin serious, but easy to fix)

remicollet commented 10 years ago

Another small issue: sundown/html/html.c is executable, please chmod it.

chobie commented 10 years ago

sundown/html/html.c is under the vmg/sundown repository. also hoedown keeps same permission. we should report it to hoedown.