chobie / php-uv

libuv php extension
185 stars 21 forks source link

Assorted fixes #57

Closed datibbaw closed 10 years ago

datibbaw commented 10 years ago

This is a collection of fixes that should improve the likelihood of it being picked up by package maintainers; it also includes a few memory fixes.

Package / build changes:

Bug fixes:

datibbaw commented 10 years ago

I understand that this is a rather large change to the project; feel free to discuss the work if you're unclear about certain things or if you outright disagree :)

rdlowrey commented 10 years ago

:+1: for --with-uv[=DIR] and --enable-httpparser

chobie commented 10 years ago

@datibbaw Thanks, this makes easy to maintain extension and publishing as PECL.

rdlowrey commented 10 years ago

I know I'm a couple of months late on this, but can I get a reminder for the logic behind adding the ext/sockets as a dependency? I know we discussed this off-board, @datibbaw, but I've forgotten what the reasons were. Might be nice to note those here for posterity.

datibbaw commented 10 years ago

@rdlowrey From what I can remember, this library has always been dependent on sockets; i.e. it won't compile without it.