Closed datibbaw closed 10 years ago
I understand that this is a rather large change to the project; feel free to discuss the work if you're unclear about certain things or if you outright disagree :)
:+1: for --with-uv[=DIR]
and --enable-httpparser
@datibbaw Thanks, this makes easy to maintain extension and publishing as PECL.
I know I'm a couple of months late on this, but can I get a reminder for the logic behind adding the ext/sockets
as a dependency? I know we discussed this off-board, @datibbaw, but I've forgotten what the reasons were. Might be nice to note those here for posterity.
@rdlowrey From what I can remember, this library has always been dependent on sockets; i.e. it won't compile without it.
This is a collection of fixes that should improve the likelihood of it being picked up by package maintainers; it also includes a few memory fixes.
Package / build changes:
libuv
; instead, link against an installation using--with-uv[=DIR]
; it doesn't yet assert a particular version, it won't build on 0.12 so that needs fixing later on.--enable-httpparser
is used and make sure it builds with and without. I've created two separate source files for ease of maintenance. Later on we could separate it into its own module (but still within the same extension).clang
didn't like those.sockets
extensions inconfig.m4
.Bug fixes:
EXPECTF
.uv_cwd()
anduv_exepath()
; it also uses theMAXPATHLEN
.