search

chocolate-doom / music-packs

Configuration files for HQ music packs [OBSOLETE - please see i_musicpacks.c]
https://www.chocolate-doom.org/wiki/index.php/Digital_music_packs
5 stars 6 forks source link

configs for ogg or mp3 instead of flac #1

Open jmtd opened 8 years ago

jmtd commented 8 years ago

... would be nice

fragglet commented 8 years ago

Worth remembering that these are example configs. I'm hoping we can get music pack authors to include config files with their packs (we have tentative approval for this from MusicallyInspired already). Normal users shouldn't need to mess around with these files for the most part.

However, you do have a point. One idea I had was to introduce an extra syntax meaning "any supported extension here" so that we make the code check for all the different extensions, rather than hard-coding one.

Note that we're only supporting .ogg and .flac since .mp3 doesn't support loop point metadata.

chungy commented 8 years ago

MP3 is also a non-free format (albeit not for much longer, seems the patents expire next year), on top of severe quality issues compared to Vorbis...

jmtd commented 8 years ago

MP3 is also a non-free format (albeit not for much longer, seems the patents expire next year), on top of severe quality issues compared to Vorbis...

Meh. I don't buy the quality issue, personally, with a modern MP3 encoder. And the ogg container is severely limited (base64 encoded album art? lol)