search

chocolatey-archive / puppet-chocolatey

Chocolatey package provider
Apache License 2.0
87 stars 135 forks source link

added parameter $ignore_proxy #144

Closed maxgaulhofer closed 8 years ago

maxgaulhofer commented 8 years ago

Closes #143

maxgaulhofer commented 8 years ago

I already created an issue earlier today https://github.com/chocolatey/puppet-chocolatey/issues/143 Let me know if i should update this with more information. I also squashed the commit :-) Is there a reason why the rspec test are failing? Thanks for your comments and hard work

ferventcoder commented 8 years ago

Yes and not your fault. We need to add something to the gemfile to keep json_pure working.

ferventcoder commented 8 years ago

For the commit changes, I'm looking for (GH-143) short message total 50 chars, an empty line, and then a message explaining the changes and why they are necessary. This is a good explanation of what is requested - https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#prepare-commits

maxgaulhofer commented 8 years ago

ok changed the commit message

ferventcoder commented 8 years ago

Also added similar to https://github.com/chocolatey/chocolatey.org/issues/433 - https://chocolatey.org/install.ps1