search

chocolatey-community / Chocolatey

PowerShell Module and DSC Resource for Chocolatey Software
MIT License
43 stars 15 forks source link

Update Install-ChocolateySoftware.ps1 #32

Closed xtqqczze closed 5 years ago

xtqqczze commented 5 years ago

Removed redundant directory exists check as CreateDirectory does nothing in this case.

xtqqczze commented 5 years ago

According to the documentation for the Directory.CreateDirectory method, "If the directory already exists, this method does not create a new directory, but it returns a DirectoryInfo object for the existing directory."

gaelcolas commented 5 years ago

Oh, apologies for not getting back to you. I actually did not see this. Feel free to @ me if I don't answer.

I'll plan to come back and have look! Thanks for the PR.

xtqqczze commented 5 years ago

@gaelcolas Ready to merge?

gaelcolas commented 5 years ago

Yeah. sorry I forgot last push. And I don't seem to have my skip CI setup on this project. Will have a look soon.