Move array from ArrayList to a generic in chocolatey.ps1

chocolatey-community / chocolatey-azuredevops

Chocolatey Extension for Azure DevOps

MIT License

20 stars 11 forks source link

Move array from ArrayList to a generic in chocolatey.ps1 #46

Closed steviecoaster closed 5 years ago

steviecoaster commented 5 years ago

ArrayLists are expensive in that they produce index output when adding/remove items from them. .Net now includes Generic.List, which can be strongly typed and produce no output on Add/remove operations.

Also removed the New-Object call, as invoking the New() method is faster than calling a cmdlet.

Expected Behavior

This should run a bit quieter now, and is future proof with non-deprecated classes.

gep13 commented 5 years ago

@steviecoaster thank you for taking the time to submit this PR.

If there is anything else that you think this extension should have in terms of functionality, please feel free to let me know, I would love some feedback.

gep13 commented 4 years ago

:tada: This issue has been resolved in version 0.3.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: