chocolatey-community / chocolatey-community-validation

Chocolatey CLI extension to bring community package validation rules to the console
Apache License 2.0
1 stars 4 forks source link

(#26) Use milestone for license URL replacement #27

Closed AdmiringWorm closed 6 months ago

AdmiringWorm commented 6 months ago

Description Of Changes

This updates the relpacement used when creating a license URL to make use of the Build Version Milestone, instead of the tag name.

Motivation and Context

This is done as in certain scenarios the tag name is an empty string and will cause an invalid URL to be generated. This causes problems when doing a release of the product, and thus changing to the milestone is more appropriate.

Testing

  1. Create a temporary tag locally
  2. Run the build using ´build.bat´
  3. Verify the created package has the correct license URL (with the name of the tag in the URL)

Operating Systems Testing

Change Types Made

Change Checklist

Related Issue

Fixes #26

AdmiringWorm commented 6 months ago

To note, once merged this should also be cherry picked into the master branch

gep13 commented 6 months ago

@AdmiringWorm thanks for getting that updated!