This implements the note rule CPMR0061 that verifies whether a package
uses a dot in its identifier, which is not recommended to do unless
absolutely necessary.
This implementation is more comprehensive than what is implemented in
package validator, where package validator will have false negatives
that this implementation will properly flag.
Motivation and Context
We want to implement as many rules as we can that is currently handled by package validator.
Testing
THis is mostly covered by unit tests, but can be manually verified by
Create a new package with a . in its identifier.
Attempt to run choco pack on the created nuspec file.
Verify the rule CPMR0061 is shown.
Rename the identifier to end with .install, but keep the other . in its identifier.
Attempt to run choco pack on the nuspec file again.
Verify the rule CPMR0061 is shown.
Rename the identifier again to remove the extra . in the identifier, but keep .install.
Attempt to run choco pack on the nuspec file.
Verify the rule CPMR0061 is no longer displayed.
Operating Systems Testing
Windows 10
Change Types Made
[ ] Bug fix (non-breaking change).
[x] Feature / Enhancement (non-breaking change).
[ ] Breaking change (fix or feature that could cause existing functionality to change).
[ ] Documentation changes.
[ ] PowerShell code changes.
Change Checklist
[ ] Requires a change to the documentation.
[ ] Documentation has been updated (no documentation needed to be updated).
Description Of Changes
This implements the note rule CPMR0061 that verifies whether a package uses a dot in its identifier, which is not recommended to do unless absolutely necessary.
This implementation is more comprehensive than what is implemented in package validator, where package validator will have false negatives that this implementation will properly flag.
Motivation and Context
We want to implement as many rules as we can that is currently handled by package validator.
Testing
THis is mostly covered by unit tests, but can be manually verified by
.
in its identifier.choco pack
on the created nuspec file.CPMR0061
is shown..install
, but keep the other.
in its identifier.choco pack
on the nuspec file again.CPMR0061
is shown..
in the identifier, but keep.install
.choco pack
on the nuspec file.CPMR0061
is no longer displayed.Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #34