chocolatey-community / chocolatey-package-requests

Please submit your package requests as issues here
Apache License 2.0
95 stars 18 forks source link

RFP - unofficial-google-chat #1310

Open dnet890 opened 2 years ago

dnet890 commented 2 years ago

Checklist

Package Details

Software project URL :https://github.com/squalou/google-chat-linux Direct download URL for the software / installer : https://github.com/squalou/google-chat-linux/releases/download/5.15.17-1/google-chat-linux_Setup_5.15.17-1.exe Software summary / short description: unofficial Google chat client wrapped in electron

github-actions[bot] commented 2 years ago

Package Request Validation

We have finished some basic validation of this request. The result of this validation can be found below:

Everything looks good to our automated checks, it is now up to a human to validate the remaining steps. No action is required yet

New Maintainer Notices

This section details some parts of the request that any upcoming maintainer may need to take into consideration.


TrID/32 - File Identifier v2.24 - (C) 2003-16 By M.Pontello
Definitions found:  14706
Analyzing...

Collecting data from file: C:\Users\RUNNER~1\AppData\Local\Temp/software.tmp
 48.8% (.EXE) Win32 Executable MS Visual C++ (generic) (31206/45/13)
 16.4% (.EXE) Win64 Executable (generic) (10523/12/4)
 10.2% (.DLL) Win32 Dynamic Link Library (generic) (6578/25/2)
  7.8% (.EXE) Win16 NE executable (generic) (5038/12/1)
  7.0% (.EXE) Win32 Executable (generic) (4505/5/1)

Please note that this check is currently in alpha, and may not be able to detect everything correctly. Humans may also be able to detect other issues with this request.

pauby commented 2 years ago

The title of whatever package is created should reflect that is unofficial. My concern is that if there is an official google chat package created in future, it will clash.

This may also cause some issues (take from https://github.com/squalou/google-chat-linux#readme):

There will be "SmartScreen" warning about how unsafe this .exe is, Windows pretending it has detected something nasty and is protecting you. I Don't Care and won't buy a certificate.

dnet890 commented 2 years ago

For chocolatey, Is windows code signed app necessary?

pauby commented 2 years ago

Not necessarily. But Windows Defender loves picking up on unsigned apps. If it can be silently installed then it should be fine. It is something that needs to be taken into consideration though.