search

chocolatey-community / chocolatey-packages-template

A template to use when setting up to create packages both manual and automatic
Apache License 2.0
83 stars 348 forks source link

Moved checksumType variables' definition to setting for Ketarin #16

Closed Elderry closed 7 years ago

ferventcoder commented 7 years ago

Unfortunately this change is not quite complete. If you are going to change the ability to pass in your own checksum type, you need to edit the ketarin settings c# to pivot on that value and calculate the proper checksum. Right now it only calculates on sha256.

Elderry commented 7 years ago

I've noticed that the ketarin's C# setting only calculates sha256, and now I just want to move the definition of checksum type variable from chocolateyInstall.ps1 to the package's ketarin setting.

ferventcoder commented 7 years ago

Yes, but you can't do that without also fixing up the c# code in the ketarin settings file to allow for it to receive other types.

HTH

Elderry commented 7 years ago

Now I have turned to AU so I won't continue this improve.

gep13 commented 7 years ago

@Elderry said... Now I have turned to AU so I won't continue this improve.

Thanks! If you can offer any help in porting to AU, we would appreciate it 👍