chocolatey-community / chocolatey-packages

Chocolatey Community Maintainers Team Packages - packages that are managed and maintained by core community team for community package repository (https://community.chocolatey.org/packages)
https://community.chocolatey.org/profiles/chocolatey-community
Apache License 2.0
436 stars 372 forks source link

(filezilla) v3.60.2 - Uninstallation script not working #1953

Closed cspeekenbrink closed 1 year ago

cspeekenbrink commented 1 year ago

Chocolatey Version

1.1.0

Chocolatey License

No response

Package Version

3.60.2 (affects probably all 3.x versions)

Current Behaviour

Uninstallation doesn't see Filezilla as installed and doesn't actually uninstall it if it is.

Expected Behaviour

Filezilla should be uninstalled, but remains. Chocolatey flags it as being uninstalled.

Steps To Reproduce

  1. Install filezilla chocolatey package version 3.60.2
  2. Uninstall filezilla
  3. Check installation, Filezilla is still there

Environment

- Operating System: Windows Server 2019
- PowerShell Version: 5.1.17763.2803
- Shell:

Chocolatey Log

2022-07-25 10:39:55,456 1276 [INFO ] - ============================================================
2022-07-25 10:39:55,799 1276 [INFO ] - Uninstalling the following packages:
2022-07-25 10:39:55,799 1276 [INFO ] - filezilla
2022-07-25 10:39:59,727 1276 [INFO ] - [NuGet] Uninstalling 'filezilla 3.60.2'.
2022-07-25 10:39:59,727 1276 [INFO ] - 
filezilla v3.60.2
2022-07-25 10:40:00,118 1276 [INFO ] - VERBOSE: Exporting function 'Format-FileSize'.
2022-07-25 10:40:00,118 1276 [INFO ] - VERBOSE: Exporting function 'Get-ChecksumValid'.
2022-07-25 10:40:00,118 1276 [INFO ] - VERBOSE: Exporting function 'Get-ChocolateyUnzip'.
2022-07-25 10:40:00,118 1276 [INFO ] - VERBOSE: Exporting function 'Get-ChocolateyWebFile'.
2022-07-25 10:40:00,118 1276 [INFO ] - VERBOSE: Exporting function 'Get-EnvironmentVariable'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-EnvironmentVariableNames'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-FtpFile'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-OSArchitectureWidth'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-PackageParameters'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-PackageParametersBuiltIn'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-ToolsLocation'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-UACEnabled'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-UninstallRegistryKey'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-VirusCheckValid'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-WebFile'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-WebFileName'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Get-WebHeaders'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-BinFile'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyEnvironmentVariable'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyExplorerMenuItem'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyFileAssociation'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyInstallPackage'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyPackage'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyPath'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyPinnedTaskBarItem'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyPowershellCommand'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyShortcut'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyVsixPackage'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyZipPackage'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Install-Vsix'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Set-EnvironmentVariable'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Set-PowerShellExitCode'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Start-ChocolateyProcessAsAdmin'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Test-ProcessAdminRights'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Uninstall-BinFile'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Uninstall-ChocolateyEnvironmentVariable'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Uninstall-ChocolateyPackage'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Uninstall-ChocolateyZipPackage'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Update-SessionEnvironment'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting function 'Write-FunctionCallLogMessage'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting alias 'Get-ProcessorBits'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting alias 'Get-OSBitness'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting alias 'Get-InstallRegistryKey'.
2022-07-25 10:40:00,134 1276 [INFO ] - VERBOSE: Exporting alias 'Generate-BinFile'.
2022-07-25 10:40:00,149 1276 [INFO ] - VERBOSE: Exporting alias 'Add-BinFile'.
2022-07-25 10:40:00,149 1276 [INFO ] - VERBOSE: Exporting alias 'Start-ChocolateyProcess'.
2022-07-25 10:40:00,149 1276 [INFO ] - VERBOSE: Exporting alias 'Invoke-ChocolateyProcess'.
2022-07-25 10:40:00,149 1276 [INFO ] - VERBOSE: Exporting alias 'Remove-BinFile'.
2022-07-25 10:40:00,149 1276 [INFO ] - VERBOSE: Exporting alias 'refreshenv'.
2022-07-25 10:40:00,165 1276 [INFO ] - VERBOSE: Loading module from path 'C:\ProgramData\chocolatey\extensions\chocolatey-compatibility\chocolatey-compatibility.psm1'.
2022-07-25 10:40:00,212 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyDesktopLink'.
2022-07-25 10:40:00,212 1276 [INFO ] - VERBOSE: Exporting function 'Write-ChocolateyFailure'.
2022-07-25 10:40:00,212 1276 [INFO ] - VERBOSE: Exporting function 'Write-ChocolateySuccess'.
2022-07-25 10:40:00,212 1276 [INFO ] - VERBOSE: Exporting function 'Write-FileUpdateLog'.
2022-07-25 10:40:00,212 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyDesktopLink'.
2022-07-25 10:40:00,212 1276 [INFO ] - VERBOSE: Importing function 'Write-ChocolateyFailure'.
2022-07-25 10:40:00,212 1276 [INFO ] - VERBOSE: Importing function 'Write-ChocolateySuccess'.
2022-07-25 10:40:00,212 1276 [INFO ] - VERBOSE: Importing function 'Write-FileUpdateLog'.
2022-07-25 10:40:00,212 1276 [INFO ] - VERBOSE: Loading module from path 'C:\ProgramData\chocolatey\extensions\chocolatey-core\chocolatey-core.psm1'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Exporting function 'Get-AppInstallLocation'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Exporting function 'Get-AvailableDriveLetter'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Exporting function 'Get-EffectiveProxy'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Exporting function 'Get-PackageCacheLocation'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Exporting function 'Get-WebContent'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Exporting function 'Register-Application'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Exporting function 'Remove-Process'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Importing function 'Get-AppInstallLocation'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Importing function 'Get-AvailableDriveLetter'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Importing function 'Get-EffectiveProxy'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Importing function 'Get-PackageCacheLocation'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Importing function 'Get-WebContent'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Importing function 'Register-Application'.
2022-07-25 10:40:00,274 1276 [INFO ] - VERBOSE: Importing function 'Remove-Process'.
2022-07-25 10:40:00,290 1276 [INFO ] - VERBOSE: Loading module from path 'C:\ProgramData\chocolatey\extensions\chocolatey-dotnetfx\chocolatey-dotnetfx.psm1'.
2022-07-25 10:40:00,290 1276 [INFO ] - VERBOSE: Exporting function 'Install-DotNetFramework'.
2022-07-25 10:40:00,290 1276 [INFO ] - VERBOSE: Exporting function 'Install-DotNetDevPack'.
2022-07-25 10:40:00,290 1276 [INFO ] - VERBOSE: Importing function 'Install-DotNetDevPack'.
2022-07-25 10:40:00,290 1276 [INFO ] - VERBOSE: Importing function 'Install-DotNetFramework'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Format-FileSize'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-ChecksumValid'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-ChocolateyUnzip'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-ChocolateyWebFile'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-EnvironmentVariable'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-EnvironmentVariableNames'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-FtpFile'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-OSArchitectureWidth'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-PackageParameters'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-PackageParametersBuiltIn'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-ToolsLocation'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-UACEnabled'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-UninstallRegistryKey'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-VirusCheckValid'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-WebFile'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-WebFileName'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Get-WebHeaders'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-BinFile'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyEnvironmentVariable'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyExplorerMenuItem'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyFileAssociation'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyInstallPackage'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyPackage'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyPath'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyPinnedTaskBarItem'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyPowershellCommand'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyShortcut'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyVsixPackage'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyZipPackage'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Install-Vsix'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Set-EnvironmentVariable'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Set-PowerShellExitCode'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Start-ChocolateyProcessAsAdmin'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Test-ProcessAdminRights'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Uninstall-BinFile'.
2022-07-25 10:40:00,305 1276 [INFO ] - VERBOSE: Exporting function 'Uninstall-ChocolateyEnvironmentVariable'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Uninstall-ChocolateyPackage'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Uninstall-ChocolateyZipPackage'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Update-SessionEnvironment'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Write-FunctionCallLogMessage'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Install-ChocolateyDesktopLink'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Write-ChocolateyFailure'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Write-ChocolateySuccess'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Write-FileUpdateLog'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Get-AppInstallLocation'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Get-AvailableDriveLetter'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Get-EffectiveProxy'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Get-PackageCacheLocation'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Get-WebContent'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Register-Application'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Remove-Process'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Install-DotNetDevPack'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting function 'Install-DotNetFramework'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting alias 'Get-ProcessorBits'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting alias 'Get-OSBitness'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting alias 'Get-InstallRegistryKey'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting alias 'Generate-BinFile'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting alias 'Add-BinFile'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting alias 'Start-ChocolateyProcess'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting alias 'Invoke-ChocolateyProcess'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting alias 'Remove-BinFile'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Exporting alias 'refreshenv'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Importing function 'Format-FileSize'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Importing function 'Get-AppInstallLocation'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Importing function 'Get-AvailableDriveLetter'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Importing function 'Get-ChecksumValid'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Importing function 'Get-ChocolateyUnzip'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Importing function 'Get-ChocolateyWebFile'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Importing function 'Get-EffectiveProxy'.
2022-07-25 10:40:00,321 1276 [INFO ] - VERBOSE: Importing function 'Get-EnvironmentVariable'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-EnvironmentVariableNames'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-FtpFile'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-OSArchitectureWidth'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-PackageCacheLocation'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-PackageParameters'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-PackageParametersBuiltIn'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-ToolsLocation'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-UACEnabled'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-UninstallRegistryKey'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-VirusCheckValid'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-WebContent'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-WebFile'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-WebFileName'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Get-WebHeaders'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-BinFile'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyDesktopLink'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyEnvironmentVariable'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyExplorerMenuItem'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyFileAssociation'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyInstallPackage'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyPackage'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyPath'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyPinnedTaskBarItem'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyPowershellCommand'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyShortcut'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyVsixPackage'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-ChocolateyZipPackage'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-DotNetDevPack'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-DotNetFramework'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Install-Vsix'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Register-Application'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Remove-Process'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Set-EnvironmentVariable'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Set-PowerShellExitCode'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Start-ChocolateyProcessAsAdmin'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Test-ProcessAdminRights'.
2022-07-25 10:40:00,337 1276 [INFO ] - VERBOSE: Importing function 'Uninstall-BinFile'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing function 'Uninstall-ChocolateyEnvironmentVariable'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing function 'Uninstall-ChocolateyPackage'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing function 'Uninstall-ChocolateyZipPackage'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing function 'Update-SessionEnvironment'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing function 'Write-ChocolateyFailure'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing function 'Write-ChocolateySuccess'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing function 'Write-FileUpdateLog'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing function 'Write-FunctionCallLogMessage'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing alias 'Add-BinFile'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing alias 'Generate-BinFile'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing alias 'Get-InstallRegistryKey'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing alias 'Get-OSBitness'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing alias 'Get-ProcessorBits'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing alias 'Invoke-ChocolateyProcess'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing alias 'refreshenv'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing alias 'Remove-BinFile'.
2022-07-25 10:40:00,352 1276 [INFO ] - VERBOSE: Importing alias 'Start-ChocolateyProcess'.
2022-07-25 10:40:00,430 1276 [INFO ] - VERBOSE: Retrieving all uninstall registry keys
2022-07-25 10:40:00,524 1276 [WARN ] - WARNING: No registry key found based on  'FileZilla Client*'
2022-07-25 10:40:00,540 1276 [WARN ] - WARNING: filezilla has already been uninstalled by other means.
2022-07-25 10:40:00,555 1276 [INFO ] -  Skipping auto uninstaller - No registry snapshot.
2022-07-25 10:40:00,634 1276 [INFO ] - [NuGet] Successfully uninstalled 'filezilla 3.60.2'.
2022-07-25 10:40:00,634 1276 [INFO ] -  filezilla has been successfully uninstalled.
2022-07-25 10:40:00,665 1276 [WARN ] - 
Chocolatey uninstalled 1/1 packages. 
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2022-07-25 10:40:03,062 6568 [INFO ] - ============================================================

Anything else?

The reason seems to be that it checks if Filezilla is installed by looking for this reg key: HKLM\Software\Filezilla Client But (probably since v3.x) this key is called: HKLM\Software\FileZilla 3

So changing this line in the uninstallscript: $softwareNamePattern = 'FileZilla Client' to: $softwareNamePattern = 'FileZilla 3' Fixes it.

AdmiringWorm commented 1 year ago

Thank you for reporting this bug.

First of all, I do find it a bit odd that the auto uninstaller didn't detect the installation, which it usually does if the software has been installed through Chocolatey CLI (at least for this package).

The reason seems to be that it checks if Filezilla is installed by looking for this reg key:

Not necessarily, it isn't the name of the key itself that it checks, but rather it is the name that is displayed when you uninstall the application manually through Programs and Features.

I do see that name has changed as well though

cspeekenbrink commented 1 year ago

First of all, I do find it a bit odd that the auto uninstaller didn't detect the installation, which it usually does if the software has been installed through Chocolatey CLI (at least for this package).

Well, Chocolatey found the installation and reports back the version number too, but somehow doesn't detect the installation from the steps in the uninstallation script.

Not necessarily, it isn't the name of the key itself that it checks, but rather it is the name that is displayed when you uninstall the application manually through Programs and Features.

Ah, that makes sense. So the value I changed in the script is not the registry key name, but the name of the app in 'Programs and features'. Thanks!

AdmiringWorm commented 1 year ago

Well, Chocolatey found the installation and reports back the version number too, but somehow doesn't detect the installation from the steps in the uninstallation script.

Chocolatey CLI itself doesn't detect it based on the uninstallation script, it has its own auto uninstaller that doesn't rely on it at all. But that is a different story. Since we have an uninstall script it should be fixed in the script itself first.

Would you be willing to submit a PR to fix this issue and correct the software name in both the chocolateyinstall.ps1 and chocolateyuninstall.ps1 scripts?

These should probably be replaceable values that get updated through the update.ps1 script since it uses the major version of the application (which it must do to prevent Filezilla Server to be picked up).

cspeekenbrink commented 1 year ago

Sure would. It would be my first though, so I'll have to get acqainted with it. Getting right to it.