chocolatey-community / chocolatey-packages

Chocolatey Community Maintainers Team Packages - packages that are managed and maintained by core community team for community package repository (https://community.chocolatey.org/packages)
https://community.chocolatey.org/profiles/chocolatey-community
Apache License 2.0
447 stars 377 forks source link

(wixtoolset) Fix validation issues #2431

Closed felfert closed 7 months ago

felfert commented 7 months ago

Description

This PR fixes multiple invalid URLs in the nuspec, as mentioned in the valdation report

Motivation and Context

Validation should be expedited, because v3.14.0 is actually a security related release.

How Has this Been Tested?

N/A

Screenshot (if appropriate, usually isn't needed):

Types of changes

Checklist:

AppVeyorBot commented 7 months ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

AppVeyorBot commented 7 months ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

AdmiringWorm commented 7 months ago

@gep13 as the code owner of this package, we need your approval before we can merge this PR.

gep13 commented 7 months ago

@felfert thank you very much for fixing this up!

felfert commented 7 months ago

@gep13, @AdmiringWorm : What I don't understand: At https://community.chocolatey.org/packages/wixtoolset/3.14.0#versionhistory i see a second validation error with the very same issues (as of today, 14:52 UTC)?! Is this some upload/caching problem?

AdmiringWorm commented 7 months ago

@gep13, @AdmiringWorm : What I don't understand: At community.chocolatey.org/packages/wixtoolset/3.14.0#versionhistory i see a second validation error with the very same issues (as of today, 14:52 UTC)?! Is this some upload/caching problem?

It shouldn't be, at least not after that long since it last ran for the package. I'll re-run the validator in the hope it was just a glitch causing it to fail, if that fail again I'll try pushing another package version.

EDIT: I have attempted to push the package again, I won't be able to do anything more until Monday, so I can only hope whatever the problem is that it was/is temporary.