(tortoisesvn) Fix finding download URL from SourceForge

WhereTheTimeWent commented 3 months ago

The current attempt of finding the download URL on SourceForge for TortoiseSVN doesn't work anymore. It now gets the URL by checking data-release-url for "downloads.sourceforge.net".

How Has this Been Tested?

I tested it with VSCode. It returned downloadable URLs. They were both downloadable with Firefox and System.Net.WebClient (PowerShell). I also ran Update-Package and it completed without errors.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[x] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
[x] The changes only affect a single package (not including meta package).

AppVeyorBot commented 3 months ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

AppVeyorBot commented 3 months ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

AppVeyorBot commented 3 months ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

AppVeyorBot commented 3 months ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

WhereTheTimeWent commented 3 months ago

Sorry for this mess. Not new to PowerShell, but new to AU and pull requests. We should now have a reliable way of updating TortoiseSVN.

AppVeyorBot commented 3 weeks ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

JPRuskin commented 3 weeks ago

Given that error, I'm going to trigger the build by pushing and removing a commit. Sorry for the noise.

AppVeyorBot commented 3 weeks ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

AppVeyorBot commented 3 weeks ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

AppVeyorBot commented 3 weeks ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

WhereTheTimeWent commented 3 weeks ago

Are there problems with my change? Update-Package and Test-Package run without issues on my end and download/install the latest version 1.14.7.29687.

JPRuskin commented 3 weeks ago

Are there problems with my change?

Not at all.

All works fine on my end too - I'm just trying to chase down the reason we're getting that failure on the AppVeyor build. It's an odd one as a) it's not a package that's in the dependency chain from TortoiseSVN and b) it's not failing in other builds yesterday/today.

pauby commented 1 week ago

@JPRuskin did you find any more on this?

chocolatey-community / chocolatey-packages