`(mumble)` Outdated, fix getting auto updates and add a required dependency

suprovsky commented 1 month ago

Description

This should fix checking Mumble version available on GitHub, resulting in properly working automatic updates, as well as a required dependency, which is not installed on Windows Server by default.

Motivation and Context

The version available in Chocolatey is 1.4.287 where the latest stable is 1.5.634. Automatic Chocolatey updates does not work because mumble.info does not work as it's been moved to www.mumble.info it seems. Updated script uses fetching version from GitHub which is more reliable. I've added vcredist140 as a dependency because without it Mumble won't work on Windows Server (which was a testing environment system).

How Has this Been Tested?

I've run update.ps1 on my local machine (Windows 11 amd64) to see if Version and URL32 is set properly. Also used a Chocolatey Test Environment to see if the package installs.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[X] All files are up to date with the latest Contributing Guidelines
[X] The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
[X] The changes only affect a single package (not including meta package).

AppVeyorBot commented 1 month ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

suprovsky commented 1 month ago

au_GetLatest() fails on:

$LatestRelease = Get-GitHubRelease -OwnerName mumble-voip -RepositoryName mumble -Latest

because the version of PowerShellForGitHub used in the AppVeyor is probably older then the current release (0.17.0) available in the PowerShell Gallery. I am not sure what to do now; should I change it to

$LatestRelease = Get-GitHubRelease mumble-voip mumble -Latest

which seems to work with simplewall or would you use a later version of this module in the AppVeyor?

pauby commented 1 month ago

AppVeyor doesn't use PowerShellForGitHub module. It uses the Get-GitHubRelease script.

AppVeyorBot commented 1 month ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

AppVeyorBot commented 1 month ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

AppVeyorBot commented 1 month ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

AppVeyorBot commented 1 month ago

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

AppVeyorBot commented 1 month ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

AppVeyorBot commented 1 month ago

:white_check_mark: Package verification completed without issues. PR is now pending human review

chocolatey-community / chocolatey-packages