search

chocolatey-community / chocolatey-test-environment

A testing setup related to how the Chocolatey Package Verifier runs testing. Used for manual testing or prior to submission
Apache License 2.0
117 stars 187 forks source link

Chocolatey Bootstraper #45

Closed GuyWhoKnowsTheGuy closed 2 years ago

GuyWhoKnowsTheGuy commented 4 years ago

Created Chocolatey package to set up a local test environment for Chocolatey packages;

mkevenaar commented 4 years ago

Please have a look to the comments I have added to the package as well:

Hi,

First of all, I want to thank you creating this package. I think this could be a good idea to package this up so new maintainers could start sooner. However we need to make some changes before we can approve this.

  1. The version of the Chocolatey test environment is currently not defined somewhere, I am discussing this with the team, but 0.10.15 is incorrect. It will probably be something like 0.1.0

  2. Please do not pin the version of vagrant / virtualbox to a specific version. If people have versions of VirtualBox / Vagrant installed, this can result in scenarios that are unexpected.

  3. Please do not use git checkout inside a package. The checkout should be of a tag, or a ZIP archive should be embedded in the package. (Please wait for a release tag.)

  4. The sahara plugin is an separate installation, please create a depended package for this.

  5. Please use the Get-ToolsLocation helper to define the folder; adding a Package Parameter to define the folder would be a great addition as well.

  6. I am not sure if you should start the vagrant box and sandbox it during installation.

This is just a quick scan of the package, there are probably more (smaller) issues to be solved when we are going forward.

Installing VirtualBox inside a VirtualBox VM is not supported, so an exemption should be added in a later state.

I would like to ask you to reach out to me on gitter (open chat button on the lower right) to discuss how to go forward. My username is mkevenaar.

Thanks for doing this!

Maurice

GuyWhoKnowsTheGuy commented 4 years ago

What's the ETA for a release, so I can bundle it with the package?

GuyWhoKnowsTheGuy commented 4 years ago

To clarify, @mkevenaar , are you suggesting the code be checked out to Get-ToolsLocation by default, and optionally to a location specified by a package parameter?

boubou commented 4 years ago

Very interesting package. Good job and thanks!

pauby commented 4 years ago

Can I also suggest that for the package you make clear it is for Virtualbox. The Chocolatey Test Environment exists for Hyper-V, VMware and Virtualbox.

pauby commented 2 years ago

There has been no update to this for some time, so I'm going to go ahead and close.